diff options
| author |   Prashant Malani <pmalani@chromium.org> | 2021-10-04 10:07:09 -0700 |
|---|---|---|
| committer |   Benson Leung <bleung@chromium.org> | 2021-10-31 15:52:39 -0700 |
| commit | 7ff22787ba49c2e66dcec92f3e2b79ef6b6a0d71 (patch) | |
| tree | 78be3c7703e7f4caed87987ba43b970c808944ac /drivers/mfd/cros_ec_dev.c | |
| parent | MAINTAINERS: Chrome: Drop Enric Balletbo i Serra (diff) | |
| download | linux-dev-7ff22787ba49c2e66dcec92f3e2b79ef6b6a0d71.tar.xz linux-dev-7ff22787ba49c2e66dcec92f3e2b79ef6b6a0d71.zip | |
platform/chrome: cros_ec_proto: Use EC struct for features
The Chrome EC's features are returned through an
ec_response_get_features struct, but they are stored in an independent
array. Although the two are effectively the same at present (2 unsigned
32 bit ints), there is the possibility that they could go out of sync.
Avoid this by only using the EC struct to store the features.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Link: https://lore.kernel.org/r/20211004170716.86601-1-pmalani@chromium.org
Signed-off-by: Benson Leung <bleung@chromium.org>
Diffstat (limited to 'drivers/mfd/cros_ec_dev.c')
| -rw-r--r-- | drivers/mfd/cros_ec_dev.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 8c08d1c55726..6ee1f410eb53 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -146,8 +146,8 @@ static int ec_device_probe(struct platform_device *pdev) ec->ec_dev = dev_get_drvdata(dev->parent); ec->dev = dev; ec->cmd_offset = ec_platform->cmd_offset; - ec->features[0] = -1U; /* Not cached yet */ - ec->features[1] = -1U; /* Not cached yet */ + ec->features.flags[0] = -1U; /* Not cached yet */ + ec->features.flags[1] = -1U; /* Not cached yet */ device_initialize(&ec->class_dev); for (i = 0; i < ARRAY_SIZE(cros_mcu_devices); i++) { |