diff options
| author |   Claudiu Beznea <claudiu.beznea@microchip.com> | 2019-12-18 14:28:27 +0200 |
|---|---|---|
| committer |   Lee Jones <lee.jones@linaro.org> | 2020-01-07 10:08:58 +0000 |
| commit | 10f9167664362bac6f44813687cf52fec9d15845 (patch) | |
| tree | 8cf0b74963b8959f3af8a94126cfd67fa489648a /drivers/mfd | |
| parent | mfd: atmel-hlcdc: Add struct device member to struct atmel_hlcdc_regmap (diff) | |
| download | linux-dev-10f9167664362bac6f44813687cf52fec9d15845.tar.xz linux-dev-10f9167664362bac6f44813687cf52fec9d15845.zip | |
mfd: atmel-hlcdc: Return in case of error
For HLCDC timing engine configurations bit ATMEL_HLCDC_SIP of
ATMEL_HLCDC_SR needs to be polled before applying new config. In case of
timeout there is no indicator about this, so, return in case of timeout
and also print a message about this.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
| -rw-r--r-- | drivers/mfd/atmel-hlcdc.c | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c index 92bfcaa62ace..3c2414ba4b01 100644 --- a/drivers/mfd/atmel-hlcdc.c +++ b/drivers/mfd/atmel-hlcdc.c @@ -40,10 +40,17 @@ static int regmap_atmel_hlcdc_reg_write(void *context, unsigned int reg, if (reg <= ATMEL_HLCDC_DIS) { u32 status; - - readl_poll_timeout_atomic(hregmap->regs + ATMEL_HLCDC_SR, - status, !(status & ATMEL_HLCDC_SIP), - 1, 100); + int ret; + + ret = readl_poll_timeout_atomic(hregmap->regs + ATMEL_HLCDC_SR, + status, + !(status & ATMEL_HLCDC_SIP), + 1, 100); + if (ret) { + dev_err(hregmap->dev, + "Timeout! Clock domain synchronization is in progress!\n"); + return ret; + } } writel(val, hregmap->regs + reg); |