aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>2014-03-12 16:50:45 +0100
committerLee Jones <lee.jones@linaro.org>2014-03-19 09:06:10 +0000
commit742766aac563ea1c28e9f86ed53db757a2872081 (patch)
tree1dd05404f302febd8915f3a6ae0b4f6806fb3ac2 /drivers/mfd
parentmfd: tps65910: Fix possible invalid pointer dereference on regmap_add_irq_chip fail (diff)
downloadlinux-dev-742766aac563ea1c28e9f86ed53db757a2872081.tar.xz
linux-dev-742766aac563ea1c28e9f86ed53db757a2872081.zip
mfd: tps65910: Fix regmap_irq_chip_data leak on mfd_add_devices fail
The tps65910_i2c_probe() allocates regmap_irq_chip in tps65910_irq_init() but it does not clean this up in case of mfd_add_devices() failure. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/tps65910.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index d6573318977f..460a014ca629 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -511,6 +511,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
regmap_irq_get_domain(tps65910->irq_data));
if (ret < 0) {
dev_err(&i2c->dev, "mfd_add_devices failed: %d\n", ret);
+ tps65910_irq_exit(tps65910);
return ret;
}