diff options
| author |   Shuah Khan <skhan@linuxfoundation.org> | 2022-04-29 15:09:13 -0600 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-05-09 15:40:15 +0200 |
| commit | f861d36e021e1ac4a0a2a1f6411d623809975d63 (patch) | |
| tree | a1a07333693e1ecd9fd27f92a800b492b3523270 /drivers/misc/cardreader | |
| parent | altera-stapl: Use swap() instead of open coding it (diff) | |
| download | linux-dev-f861d36e021e1ac4a0a2a1f6411d623809975d63.tar.xz linux-dev-f861d36e021e1ac4a0a2a1f6411d623809975d63.zip | |
misc: rtsx: set NULL intfdata when probe fails
rtsx_usb_probe() doesn't call usb_set_intfdata() to null out the
interface pointer when probe fails. This leaves a stale pointer.
Noticed the missing usb_set_intfdata() while debugging an unrelated
invalid DMA mapping problem.
Fix it with a call to usb_set_intfdata(..., NULL).
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20220429210913.46804-1-skhan@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/cardreader')
| -rw-r--r-- | drivers/misc/cardreader/rtsx_usb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/misc/cardreader/rtsx_usb.c b/drivers/misc/cardreader/rtsx_usb.c index 59eda55d92a3..1ef9b61077c4 100644 --- a/drivers/misc/cardreader/rtsx_usb.c +++ b/drivers/misc/cardreader/rtsx_usb.c @@ -667,6 +667,7 @@ static int rtsx_usb_probe(struct usb_interface *intf, return 0; out_init_fail: + usb_set_intfdata(ucr->pusb_intf, NULL); usb_free_coherent(ucr->pusb_dev, IOBUF_SIZE, ucr->iobuf, ucr->iobuf_dma); return ret; |