diff options
| author |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-11 20:32:13 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-06-12 13:37:03 +0200 |
| commit | 5a2338dbf97fac3a93e2ffefa5ab907ac5a9ba56 (patch) | |
| tree | 46188dd9ed03210e55d271bcdda5ad1007b6e5eb /drivers/misc | |
| parent | vmw_balloon: no need to check return value of debugfs_create functions (diff) | |
| download | linux-dev-5a2338dbf97fac3a93e2ffefa5ab907ac5a9ba56.tar.xz linux-dev-5a2338dbf97fac3a93e2ffefa5ab907ac5a9ba56.zip | |
lkdtm: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/lkdtm/core.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/drivers/misc/lkdtm/core.c b/drivers/misc/lkdtm/core.c index 1972dad966f5..bae3b3763f3e 100644 --- a/drivers/misc/lkdtm/core.c +++ b/drivers/misc/lkdtm/core.c @@ -429,22 +429,13 @@ static int __init lkdtm_module_init(void) /* Register debugfs interface */ lkdtm_debugfs_root = debugfs_create_dir("provoke-crash", NULL); - if (!lkdtm_debugfs_root) { - pr_err("creating root dir failed\n"); - return -ENODEV; - } /* Install debugfs trigger files. */ for (i = 0; i < ARRAY_SIZE(crashpoints); i++) { struct crashpoint *cur = &crashpoints[i]; - struct dentry *de; - de = debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root, - cur, &cur->fops); - if (de == NULL) { - pr_err("could not create crashpoint %s\n", cur->name); - goto out_err; - } + debugfs_create_file(cur->name, 0644, lkdtm_debugfs_root, cur, + &cur->fops); } /* Install crashpoint if one was selected. */ |