diff options
| author |   Yuri Nudelman <ynudelman@habana.ai> | 2022-05-11 14:50:02 +0300 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-05-22 21:01:21 +0200 |
| commit | 83617f5a87f4ad8403bf1177708fedc98b0a1059 (patch) | |
| tree | 4e7566cd6dc19670de9b0034a8f8c2bbb27d75c4 /drivers/misc | |
| parent | habanalabs: return -EFAULT on copy_to_user error (diff) | |
| download | linux-dev-83617f5a87f4ad8403bf1177708fedc98b0a1059.tar.xz linux-dev-83617f5a87f4ad8403bf1177708fedc98b0a1059.zip | |
habanalabs: order memory manager messages
Changing format of memory manager messages to make it more readable. In
addition, reducing the priority of a warning on missing handle during
put. This scenario is not an indication of a problem and may happen in
a legal flow, when handle is put from multiple flows. For example, in
timeout and completion.
Signed-off-by: Yuri Nudelman <ynudelman@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/habanalabs/common/memory_mgr.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/misc/habanalabs/common/memory_mgr.c b/drivers/misc/habanalabs/common/memory_mgr.c index 0ddfebe3a9ef..3dbe388d592d 100644 --- a/drivers/misc/habanalabs/common/memory_mgr.c +++ b/drivers/misc/habanalabs/common/memory_mgr.c @@ -26,7 +26,7 @@ struct hl_mmap_mem_buf *hl_mmap_mem_buf_get(struct hl_mem_mgr *mmg, u64 handle) if (!buf) { spin_unlock(&mmg->lock); dev_warn(mmg->dev, - "Buff get failed, no match to handle %llu\n", handle); + "Buff get failed, no match to handle %#llx\n", handle); return NULL; } kref_get(&buf->refcount); @@ -119,8 +119,8 @@ int hl_mmap_mem_buf_put_handle(struct hl_mem_mgr *mmg, u64 handle) buf = idr_find(&mmg->handles, lower_32_bits(handle >> PAGE_SHIFT)); if (!buf) { spin_unlock(&mmg->lock); - dev_warn(mmg->dev, - "Buff put failed, no match to handle %llu\n", handle); + dev_dbg(mmg->dev, + "Buff put failed, no match to handle %#llx\n", handle); return -EINVAL; } @@ -246,7 +246,7 @@ int hl_mem_mgr_mmap(struct hl_mem_mgr *mmg, struct vm_area_struct *vma, buf = hl_mmap_mem_buf_get(mmg, handle); if (!buf) { dev_err(mmg->dev, - "Memory mmap failed, no match to handle %llu\n", handle); + "Memory mmap failed, no match to handle %#llx\n", handle); return -EINVAL; } |