diff options
| author |   Ulf Hansson <ulf.hansson@linaro.org> | 2020-04-30 11:16:37 +0200 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2020-05-28 11:21:02 +0200 |
| commit | f04086c225da11ad16d7f9a2fbca6483ab16dded (patch) | |
| tree | 0bf986c607b93fa0e9950f90b117cb2d67ba7039 /drivers/mmc/core/sdio.c | |
| parent | mmc: sdhci-msm: Fix error handling for dev_pm_opp_of_add_table() (diff) | |
| download | linux-dev-f04086c225da11ad16d7f9a2fbca6483ab16dded.tar.xz linux-dev-f04086c225da11ad16d7f9a2fbca6483ab16dded.zip | |
mmc: sdio: Fix potential NULL pointer error in mmc_sdio_init_card()
During some scenarios mmc_sdio_init_card() runs a retry path for the UHS-I
specific initialization, which leads to removal of the previously allocated
card. A new card is then re-allocated while retrying.
However, in one of the corresponding error paths we may end up to remove an
already removed card, which likely leads to a NULL pointer exception. So,
let's fix this.
Fixes: 5fc3d80ef496 ("mmc: sdio: don't use rocr to check if the card could support UHS mode")
Cc: <stable@vger.kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20200430091640.455-2-ulf.hansson@linaro.org
Diffstat (limited to 'drivers/mmc/core/sdio.c')
| -rw-r--r-- | drivers/mmc/core/sdio.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c index ebb387aa5158..d35679e6e6aa 100644 --- a/drivers/mmc/core/sdio.c +++ b/drivers/mmc/core/sdio.c @@ -718,9 +718,8 @@ try_again: /* Retry init sequence, but without R4_18V_PRESENT. */ retries = 0; goto try_again; - } else { - goto remove; } + return err; } /* |