diff options
| author |   Russell King <rmk+kernel@arm.linux.org.uk> | 2014-04-25 12:59:05 +0100 |
|---|---|---|
| committer |   Chris Ball <chris@printf.net> | 2014-05-22 07:26:33 -0400 |
| commit | 10cf4963007ccfad335f57a598d5fd3f7c83c606 (patch) | |
| tree | 03b258406e337c31697eb36c6acee07155bb09c3 /drivers/mmc | |
| parent | mmc: sdhci-esdhc-imx: avoid DMA to kernel stack (diff) | |
| download | linux-dev-10cf4963007ccfad335f57a598d5fd3f7c83c606.tar.xz linux-dev-10cf4963007ccfad335f57a598d5fd3f7c83c606.zip | |
mmc: sdhci-esdhc-imx: comment runtime_pm_get_sync() in esdhc_prepare_tuning()
It is far from obvious what this is doing, and it looks like it's an
unbalanced runtime_pm_get() call. However, the put is inside
sdhci_tasklet_finish(), so it's not unbalanced at all. This should
be documented so people know what's going on here. Do so.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Tested-by: Markus Pargmann <mpa@pengutronix.de>
Tested-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Chris Ball <chris@printf.net>
Diffstat (limited to 'drivers/mmc')
| -rw-r--r-- | drivers/mmc/host/sdhci-esdhc-imx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 5acfe2fc4fe0..eb7a13796bcb 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -695,6 +695,7 @@ static void esdhc_prepare_tuning(struct sdhci_host *host, u32 val) /* FIXME: delay a bit for card to be ready for next tuning due to errors */ mdelay(1); + /* This is balanced by the runtime put in sdhci_tasklet_finish */ pm_runtime_get_sync(host->mmc->parent); reg = readl(host->ioaddr + ESDHC_MIX_CTRL); reg |= ESDHC_MIX_CTRL_EXE_TUNE | ESDHC_MIX_CTRL_SMPCLK_SEL | |