diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2020-07-14 17:14:10 +0300 |
|---|---|---|
| committer |   Ulf Hansson <ulf.hansson@linaro.org> | 2020-07-24 11:51:40 +0200 |
| commit | 907be2a62e4522c3dc3c298a213ccc741bd22732 (patch) | |
| tree | 5a20c783444a12e74f9f2e52e7fd44d03a36fcc6 /drivers/mmc | |
| parent | dt-bindings: mmc: renesas,sdhi: convert to YAML (diff) | |
| download | linux-dev-907be2a62e4522c3dc3c298a213ccc741bd22732.tar.xz linux-dev-907be2a62e4522c3dc3c298a213ccc741bd22732.zip | |
mmc: sdhci: Fix a potential uninitialized variable
Smatch complains that "ret" can be used without being initialized.
drivers/mmc/host/sdhci.c
4383 if (!IS_ERR(mmc->supply.vqmmc)) {
4384 if (enable_vqmmc) {
^^^^^^^^^^^^
4385 ret = regulator_enable(mmc->supply.vqmmc);
^^^^^
4386 host->sdhci_core_to_disable_vqmmc = !ret;
4387 }
"ret" is only initialized when "enable_vqmmc" is true.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200714141410.GB314989@mwanda
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
| -rw-r--r-- | drivers/mmc/host/sdhci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index d3b62fc5c661..3d272063d785 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -4104,7 +4104,7 @@ int sdhci_setup_host(struct sdhci_host *host) unsigned int ocr_avail; unsigned int override_timeout_clk; u32 max_clk; - int ret; + int ret = 0; bool enable_vqmmc = false; WARN_ON(host == NULL); |