aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorJerome Brunet <jbrunet@baylibre.com>2019-04-23 11:02:30 +0200
committerUlf Hansson <ulf.hansson@linaro.org>2019-05-06 11:55:39 +0200
commit9c5fdb07a28d730d4907d48905f06680691851e8 (patch)
tree043e5f1278624bcf116c3ea211c1d943e1d0b159 /drivers/mmc
parentmmc: meson-gx: remove open coded read with timeout (diff)
downloadlinux-dev-9c5fdb07a28d730d4907d48905f06680691851e8.tar.xz
linux-dev-9c5fdb07a28d730d4907d48905f06680691851e8.zip
mmc: meson-gx: ack only raised irq
This is merely a clean up. It makes sense to only ack raised irqs instead of acking everything all the time. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Kevin Hilman <khilman@baylibre.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/host/meson-gx-mmc.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 2deeacc051b1..8b690ecde4c5 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1082,9 +1082,6 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id)
}
out:
- /* ack all enabled interrupts */
- writel(irq_en, host->regs + SD_EMMC_STATUS);
-
if (cmd->error) {
/* Stop desc in case of errors */
u32 start = readl(host->regs + SD_EMMC_START);
@@ -1096,6 +1093,9 @@ out:
if (ret == IRQ_HANDLED)
meson_mmc_request_done(host->mmc, cmd->mrq);
+ /* ack all raised interrupts */
+ writel(status, host->regs + SD_EMMC_STATUS);
+
return ret;
}