diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-02-20 15:29:53 +0100 |
|---|---|---|
| committer |   Ulf Hansson <ulf.hansson@linaro.org> | 2021-03-30 11:41:59 +0200 |
| commit | e29c84857e2d51aa017ce04284b962742fb97d9e (patch) | |
| tree | 240135c65f260e10c91be01983b1d50f5b4529a0 /drivers/mmc | |
| parent | mmc: uniphier-sd: Fix an error handling path in uniphier_sd_probe() (diff) | |
| download | linux-dev-e29c84857e2d51aa017ce04284b962742fb97d9e.tar.xz linux-dev-e29c84857e2d51aa017ce04284b962742fb97d9e.zip | |
mmc: uniphier-sd: Fix a resource leak in the remove function
A 'tmio_mmc_host_free()' call is missing in the remove function, in order
to balance a 'tmio_mmc_host_alloc()' call in the probe.
This is done in the error handling path of the probe, but not in the remove
function.
Add the missing call.
Fixes: 3fd784f745dd ("mmc: uniphier-sd: add UniPhier SD/eMMC controller driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
Link: https://lore.kernel.org/r/20210220142953.918608-1-christophe.jaillet@wanadoo.fr
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
| -rw-r--r-- | drivers/mmc/host/uniphier-sd.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 6f0f05466917..ccbf9885a52b 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -660,6 +660,7 @@ static int uniphier_sd_remove(struct platform_device *pdev) tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); + tmio_mmc_host_free(host); return 0; } |