diff options
| author |   Boris Brezillon <boris.brezillon@bootlin.com> | 2018-05-22 12:55:14 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2018-05-22 11:56:34 +0100 |
| commit | 1e07392e7b147fd15082f9b755fc249e853f9b96 (patch) | |
| tree | 6b587cdbd262bc08acd816c7171846646ee9fed0 /drivers/mtd/devices/m25p80.c | |
| parent | spi: omap2-mcspi: Remove unnecessary pm_runtime_force_suspend() (diff) | |
| download | linux-dev-1e07392e7b147fd15082f9b755fc249e853f9b96.tar.xz linux-dev-1e07392e7b147fd15082f9b755fc249e853f9b96.zip | |
mtd: devices: m25p80: Use spi_mem_set_drvdata() instead of spi_set_drvdata()
SPI mem drivers should use spi_mem_set_drvdata() not spi_set_drvdata()
to store their private data. Using spi_set_drvdata() will mess the
spi -> spi-mem link up and cause a kernel panic at shutdown or
device removal time.
Fixes: 4120f8d158ef ("mtd: spi-nor: Use the spi_mem_xx() API")
Reported-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Marek Vasut <marek.vasut+renesas@gmail.com> on R8A7791 Porter
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/mtd/devices/m25p80.c')
| -rw-r--r-- | drivers/mtd/devices/m25p80.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 3dc022d3b53e..e84563d2067f 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -182,7 +182,7 @@ static int m25p_probe(struct spi_mem *spimem) spi_nor_set_flash_node(nor, spi->dev.of_node); nor->priv = flash; - spi_set_drvdata(spi, flash); + spi_mem_set_drvdata(spimem, flash); flash->spimem = spimem; if (spi->mode & SPI_RX_QUAD) { |