diff options
| author |   Brian Norris <computersforpeace@gmail.com> | 2017-05-01 17:04:50 -0700 |
|---|---|---|
| committer |   Boris Brezillon <boris.brezillon@free-electrons.com> | 2017-05-22 09:42:29 +0200 |
| commit | 44d4182e23c555cbfa8b8a0ad2d94664d23850d3 (patch) | |
| tree | aaa0c1d2881e3fd6bf69e37c91869a338113ef72 /drivers/mtd/nand/nand_base.c | |
| parent | Linux 4.12-rc2 (diff) | |
| download | linux-dev-44d4182e23c555cbfa8b8a0ad2d94664d23850d3.tar.xz linux-dev-44d4182e23c555cbfa8b8a0ad2d94664d23850d3.zip | |
mtd: nand: don't leak buffers when ->scan_bbt() fails
This bug seems to have been here forever, although we came close to
fixing all of them in [1]!
[1] 11eaf6df1cce ("mtd: nand: Remove BUG() abuse in nand_scan_tail")
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Acked-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Diffstat (limited to 'drivers/mtd/nand/nand_base.c')
| -rw-r--r-- | drivers/mtd/nand/nand_base.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index d474378ed810..66782291a762 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -4842,7 +4842,11 @@ int nand_scan_tail(struct mtd_info *mtd) return 0; /* Build bad block table */ - return chip->scan_bbt(mtd); + ret = chip->scan_bbt(mtd); + if (ret) + goto err_free; + return 0; + err_free: if (nbuf) { kfree(nbuf->databuf); |