diff options
| author |   Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-19 14:59:58 +0200 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-31 10:53:34 +0200 |
| commit | 5ecbba617446dbe1ec3241fa6362cce68838671d (patch) | |
| tree | 0b5624e5668a88f1edf680f464f621165fff3ad3 /drivers/mtd/nand/raw/marvell_nand.c | |
| parent | mtd: rawnand: lpc32xx_slc: Stop using nand_release() (diff) | |
| download | linux-dev-5ecbba617446dbe1ec3241fa6362cce68838671d.tar.xz linux-dev-5ecbba617446dbe1ec3241fa6362cce68838671d.zip | |
mtd: rawnand: marvell: Stop using nand_release()
This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().
Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-26-miquel.raynal@bootlin.com
Diffstat (limited to 'drivers/mtd/nand/raw/marvell_nand.c')
| -rw-r--r-- | drivers/mtd/nand/raw/marvell_nand.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index a79ce4bdd31c..260a0430313e 100644 --- a/drivers/mtd/nand/raw/marvell_nand.c +++ b/drivers/mtd/nand/raw/marvell_nand.c @@ -2676,9 +2676,14 @@ static int marvell_nand_chip_init(struct device *dev, struct marvell_nfc *nfc, static void marvell_nand_chips_cleanup(struct marvell_nfc *nfc) { struct marvell_nand_chip *entry, *temp; + struct nand_chip *chip; + int ret; list_for_each_entry_safe(entry, temp, &nfc->chips, node) { - nand_release(&entry->chip); + chip = &entry->chip; + ret = mtd_device_unregister(nand_to_mtd(chip)); + WARN_ON(ret); + nand_cleanup(chip); list_del(&entry->node); } } |