diff options
| author |   Nicholas Mc Guire <hofrat@osadl.org> | 2015-03-13 07:54:46 -0400 |
|---|---|---|
| committer |   Brian Norris <computersforpeace@gmail.com> | 2015-05-06 23:48:04 -0700 |
| commit | 818a45b1d7fbd8c55a4248fe6cd0995e06db04be (patch) | |
| tree | 5d03efb07b4e8a1e6c1622f45bc1b80155de24c2 /drivers/mtd/nand | |
| parent | mtd: fsmc_nand: fix handling of wait_for_completion_timeout return value (diff) | |
| download | linux-dev-818a45b1d7fbd8c55a4248fe6cd0995e06db04be.tar.xz linux-dev-818a45b1d7fbd8c55a4248fe6cd0995e06db04be.zip | |
mtd: fsmc_nand: match wait_for_completion_timeout return type
return type of wait_for_completion_timeout is unsigned long not int. An
appropriately named unsigned long is added and the assignment fixed up.
This not only should help readability but also handles corner cases
properly.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd/nand')
| -rw-r--r-- | drivers/mtd/nand/fsmc_nand.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c index b6306b19a31a..793872f18065 100644 --- a/drivers/mtd/nand/fsmc_nand.c +++ b/drivers/mtd/nand/fsmc_nand.c @@ -562,6 +562,7 @@ static int dma_xfer(struct fsmc_nand_data *host, void *buffer, int len, dma_cookie_t cookie; unsigned long flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT; int ret; + unsigned long time_left; if (direction == DMA_TO_DEVICE) chan = host->write_dma_chan; @@ -601,10 +602,10 @@ static int dma_xfer(struct fsmc_nand_data *host, void *buffer, int len, dma_async_issue_pending(chan); - ret = + time_left = wait_for_completion_timeout(&host->dma_access_complete, msecs_to_jiffies(3000)); - if (ret == 0) { + if (time_left == 0) { dmaengine_terminate_all(chan); dev_err(host->dev, "wait_for_completion_timeout\n"); ret = -ETIMEDOUT; |