diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2013-12-29 23:47:19 +0100 |
|---|---|---|
| committer |   Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-01-02 17:16:01 +0200 |
| commit | 4d525145a6f12b8835795beb833444d3da48fd05 (patch) | |
| tree | bde316c38564d55bc5e6d1bdf110c395e1691528 /drivers/mtd/ubi/build.c | |
| parent | Linux 3.13-rc6 (diff) | |
| download | linux-dev-4d525145a6f12b8835795beb833444d3da48fd05.tar.xz linux-dev-4d525145a6f12b8835795beb833444d3da48fd05.zip | |
UBI: fix error return code
Set the return variable to an error code as done elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'drivers/mtd/ubi/build.c')
| -rw-r--r-- | drivers/mtd/ubi/build.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index e05dc6298c1d..57deae961429 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -1245,8 +1245,10 @@ static int __init ubi_init(void) ubi_wl_entry_slab = kmem_cache_create("ubi_wl_entry_slab", sizeof(struct ubi_wl_entry), 0, 0, NULL); - if (!ubi_wl_entry_slab) + if (!ubi_wl_entry_slab) { + err = -ENOMEM; goto out_dev_unreg; + } err = ubi_debugfs_init(); if (err) |