diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2016-10-15 17:00:11 +0100 |
|---|---|---|
| committer |   Richard Weinberger <richard@nod.at> | 2016-10-20 00:06:00 +0200 |
| commit | a15cf34fed779d3d49d76e3a7e63bd0132b6a458 (patch) | |
| tree | b2dd79e913df18993df02f3bca0223c1fe21a6c3 /drivers/mtd/ubi/fastmap.c | |
| parent | ubifs: Fix xattr_names length in exit paths (diff) | |
| download | linux-dev-a15cf34fed779d3d49d76e3a7e63bd0132b6a458.tar.xz linux-dev-a15cf34fed779d3d49d76e3a7e63bd0132b6a458.zip | |
ubi: fix swapped arguments to call to ubi_alloc_aeb
Static analysis by CoverityScan detected the ec and pnum
arguments are in the wrong order on a call to ubi_alloc_aeb.
Swap the order to fix this.
Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'drivers/mtd/ubi/fastmap.c')
| -rw-r--r-- | drivers/mtd/ubi/fastmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index d6384d965788..2ff62157d3bb 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -287,7 +287,7 @@ static int update_vol(struct ubi_device *ubi, struct ubi_attach_info *ai, /* new_aeb is newer */ if (cmp_res & 1) { - victim = ubi_alloc_aeb(ai, aeb->ec, aeb->pnum); + victim = ubi_alloc_aeb(ai, aeb->pnum, aeb->ec); if (!victim) return -ENOMEM; |