diff options
| author |   Richard Weinberger <richard@nod.at> | 2015-09-22 23:58:07 +0200 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2015-09-29 12:47:04 +0200 |
| commit | 281fda27673f833a01d516658a64d22a32c8e072 (patch) | |
| tree | b00db9a22f925bc2156238f0065b0b4525b2ef5e /drivers/mtd | |
| parent | UBIFS: Kill unneeded locking in ubifs_init_security (diff) | |
| download | linux-dev-281fda27673f833a01d516658a64d22a32c8e072.tar.xz linux-dev-281fda27673f833a01d516658a64d22a32c8e072.zip | |
UBI: Validate data_size
Make sure that data_size is less than LEB size.
Otherwise a handcrafted UBI image is able to trigger
an out of bounds memory access in ubi_compare_lebs().
Cc: stable@vger.kernel.org
Signed-off-by: Richard Weinberger <richard@nod.at>
Reviewed-by: David Gstir <david@sigma-star.at>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/ubi/io.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c index 5bbd1f094f4e..1fc23e48fe8e 100644 --- a/drivers/mtd/ubi/io.c +++ b/drivers/mtd/ubi/io.c @@ -926,6 +926,11 @@ static int validate_vid_hdr(const struct ubi_device *ubi, goto bad; } + if (data_size > ubi->leb_size) { + ubi_err(ubi, "bad data_size"); + goto bad; + } + if (vol_type == UBI_VID_STATIC) { /* * Although from high-level point of view static volumes may |