diff options
| author |   Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-15 11:33:34 +0530 |
|---|---|---|
| committer |   Tudor Ambarus <tudor.ambarus@microchip.com> | 2019-08-28 12:40:31 +0300 |
| commit | 7ae2227b1c1928cfc8220ca6383c757b185fcf32 (patch) | |
| tree | 082bd363b65b5491995c66513a697c707003faa7 /drivers/mtd | |
| parent | mtd: spi-nor: aspeed-smc: Add of_node_put() (diff) | |
| download | linux-dev-7ae2227b1c1928cfc8220ca6383c757b185fcf32.tar.xz linux-dev-7ae2227b1c1928cfc8220ca6383c757b185fcf32.zip | |
mtd: spi-nor: hisi-sfc: Add of_node_put() before break
Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop, there
is no put, thus causing a memory leak. Hence add an of_node_put before
the break.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/spi-nor/hisi-sfc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mtd/spi-nor/hisi-sfc.c b/drivers/mtd/spi-nor/hisi-sfc.c index dea43ea3eea3..6dac9dd8bf42 100644 --- a/drivers/mtd/spi-nor/hisi-sfc.c +++ b/drivers/mtd/spi-nor/hisi-sfc.c @@ -401,6 +401,7 @@ static int hisi_spi_nor_register_all(struct hifmc_host *host) if (host->num_chip == HIFMC_MAX_CHIP_NUM) { dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n"); + of_node_put(np); break; } } |