diff options
| author |   Richard Weinberger <richard@nod.at> | 2014-09-19 17:37:56 +0200 |
|---|---|---|
| committer |   Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-09-24 15:36:16 +0300 |
| commit | b91671bb23a79c32a23b0ad5d6e6ad292bb21bdf (patch) | |
| tree | bb544e7b059228789411b4a601ad6e2157a38e08 /drivers/mtd | |
| parent | UBI: return on error in rename_volumes() (diff) | |
| download | linux-dev-b91671bb23a79c32a23b0ad5d6e6ad292bb21bdf.tar.xz linux-dev-b91671bb23a79c32a23b0ad5d6e6ad292bb21bdf.zip | |
UBI: Fix livelock in produce_free_peb()
The while loop in produce_free_peb() assumes that each work will produce a
free PEB. This is not true.
If ubi->works_count is 1 and the only scheduled work is the
wear_leveling_worker() produce_free_peb() can loop forever in case
nobody schedules an erase work.
Fix this issue by checking in the while loop whether work is scheduled.
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/ubi/wl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c index 20f491713145..32b3c1486a05 100644 --- a/drivers/mtd/ubi/wl.c +++ b/drivers/mtd/ubi/wl.c @@ -272,7 +272,7 @@ static int produce_free_peb(struct ubi_device *ubi) { int err; - while (!ubi->free.rb_node) { + while (!ubi->free.rb_node && ubi->works_count) { spin_unlock(&ubi->wl_lock); dbg_wl("do one work synchronously"); |