diff options
| author |   Saubhik Mukherjee <saubhik.mukherjee@gmail.com> | 2021-05-24 19:07:12 +0530 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-05-24 14:00:32 -0700 |
| commit | a4dd4fc6105e54393d637450a11d4cddb5fabc4f (patch) | |
| tree | 27225309b26e327b6b714fed294acac555f24a46 /drivers/net/appletalk/cops.c | |
| parent | Merge branch 'sja1105-fixes' (diff) | |
| download | linux-dev-a4dd4fc6105e54393d637450a11d4cddb5fabc4f.tar.xz linux-dev-a4dd4fc6105e54393d637450a11d4cddb5fabc4f.zip | |
net: appletalk: cops: Fix data race in cops_probe1
In cops_probe1(), there is a write to dev->base_addr after requesting an
interrupt line and registering the interrupt handler cops_interrupt().
The handler might be called in parallel to handle an interrupt.
cops_interrupt() tries to read dev->base_addr leading to a potential
data race. So write to dev->base_addr before calling request_irq().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Saubhik Mukherjee <saubhik.mukherjee@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/appletalk/cops.c')
| -rw-r--r-- | drivers/net/appletalk/cops.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/appletalk/cops.c b/drivers/net/appletalk/cops.c index ba8e70a8e312..6b12ce822e51 100644 --- a/drivers/net/appletalk/cops.c +++ b/drivers/net/appletalk/cops.c @@ -327,6 +327,8 @@ static int __init cops_probe1(struct net_device *dev, int ioaddr) break; } + dev->base_addr = ioaddr; + /* Reserve any actual interrupt. */ if (dev->irq) { retval = request_irq(dev->irq, cops_interrupt, 0, dev->name, dev); @@ -334,8 +336,6 @@ static int __init cops_probe1(struct net_device *dev, int ioaddr) goto err_out; } - dev->base_addr = ioaddr; - lp = netdev_priv(dev); spin_lock_init(&lp->lock); |