diff options
| author |   Joe Perches <joe@perches.com> | 2015-05-05 10:05:58 -0700 |
|---|---|---|
| committer |   Michael Grzeschik <m.grzeschik@pengutronix.de> | 2015-09-23 08:44:24 +0200 |
| commit | 5628d98fc5e99e29f2a480d4a7b1faba94a0d422 (patch) | |
| tree | 768f771fc36537816f9b056db825a3f7acbf262b /drivers/net/arcnet | |
| parent | arcnet: Move EXPORT_SYMBOL after declarations (diff) | |
| download | linux-dev-5628d98fc5e99e29f2a480d4a7b1faba94a0d422.tar.xz linux-dev-5628d98fc5e99e29f2a480d4a7b1faba94a0d422.zip | |
arcnet: Remove unnecessary OOM messages
Alloc failures have generic stack dumps so these are redundant.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Diffstat (limited to 'drivers/net/arcnet')
| -rw-r--r-- | drivers/net/arcnet/arc-rawmode.c | 1 | ||||
| -rw-r--r-- | drivers/net/arcnet/capmode.c | 5 | ||||
| -rw-r--r-- | drivers/net/arcnet/com20020-pci.c | 4 | ||||
| -rw-r--r-- | drivers/net/arcnet/rfc1051.c | 1 | ||||
| -rw-r--r-- | drivers/net/arcnet/rfc1201.c | 1 |
5 files changed, 2 insertions, 10 deletions
diff --git a/drivers/net/arcnet/arc-rawmode.c b/drivers/net/arcnet/arc-rawmode.c index e4a27029e1c0..7fc5b0420d62 100644 --- a/drivers/net/arcnet/arc-rawmode.c +++ b/drivers/net/arcnet/arc-rawmode.c @@ -98,7 +98,6 @@ static void rx(struct net_device *dev, int bufnum, skb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC); if (skb == NULL) { - arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n"); dev->stats.rx_dropped++; return; } diff --git a/drivers/net/arcnet/capmode.c b/drivers/net/arcnet/capmode.c index 92b553e70d5c..de80d9e0e53f 100644 --- a/drivers/net/arcnet/capmode.c +++ b/drivers/net/arcnet/capmode.c @@ -57,7 +57,6 @@ static void rx(struct net_device *dev, int bufnum, skb = alloc_skb(length + ARC_HDR_SIZE + sizeof(int), GFP_ATOMIC); if (skb == NULL) { - arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n"); dev->stats.rx_dropped++; return; } @@ -197,10 +196,8 @@ static int ack_tx(struct net_device *dev, int acked) /* Now alloc a skb to send back up through the layers: */ ackskb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC); - if (ackskb == NULL) { - arc_printk(D_NORMAL, dev, "Memory squeeze, can't acknowledge\n"); + if (ackskb == NULL) goto free_outskb; - } skb_put(ackskb, length + ARC_HDR_SIZE); ackskb->dev = dev; diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index 7247addf46de..fc6809b43f8f 100644 --- a/drivers/net/arcnet/com20020-pci.c +++ b/drivers/net/arcnet/com20020-pci.c @@ -142,10 +142,8 @@ static int com20020pci_probe(struct pci_dev *pdev, const struct pci_device_id *i card = devm_kzalloc(&pdev->dev, sizeof(struct com20020_dev), GFP_KERNEL); - if (!card) { - pr_err("%s out of memory!\n", __func__); + if (!card) return -ENOMEM; - } card->index = i; card->pci_priv = priv; diff --git a/drivers/net/arcnet/rfc1051.c b/drivers/net/arcnet/rfc1051.c index d5a0f907ac82..7e7eda5b0232 100644 --- a/drivers/net/arcnet/rfc1051.c +++ b/drivers/net/arcnet/rfc1051.c @@ -134,7 +134,6 @@ static void rx(struct net_device *dev, int bufnum, skb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC); if (skb == NULL) { - arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n"); dev->stats.rx_dropped++; return; } diff --git a/drivers/net/arcnet/rfc1201.c b/drivers/net/arcnet/rfc1201.c index 3dae14166120..9040a8be155c 100644 --- a/drivers/net/arcnet/rfc1201.c +++ b/drivers/net/arcnet/rfc1201.c @@ -179,7 +179,6 @@ static void rx(struct net_device *dev, int bufnum, skb = alloc_skb(length + ARC_HDR_SIZE, GFP_ATOMIC); if (skb == NULL) { - arc_printk(D_NORMAL, dev, "Memory squeeze, dropping packet\n"); dev->stats.rx_dropped++; return; } |