diff options
| author |   Martin Gebert <martin.gebert@alpha-bit.de> | 2008-07-23 09:40:09 +0200 |
|---|---|---|
| committer |   Jeff Garzik <jgarzik@redhat.com> | 2008-09-24 18:48:58 -0400 |
| commit | 533763d34862101090f8563aa9da202583b2423d (patch) | |
| tree | 516d09b5cd590c27f4a15f7740a617265ac143e7 /drivers/net/au1000_eth.c | |
| parent | MAINTAINERS: add Atheros maintainer for atlx (diff) | |
| download | linux-dev-533763d34862101090f8563aa9da202583b2423d.tar.xz linux-dev-533763d34862101090f8563aa9da202583b2423d.zip | |
[netdrvr] au1000_eth: Spinlock initialisation fix
Seems like the spinlock for the AU1x00 ethernet device is initialised too
late, as it is already used in enable_mac(), which is called via
mii_probe() before the init takes place.
The attached patch is working here for a Linux Au1100 2.6.22.6 kernel,
and as far as I checked should also be applicable to the current head
(just line numbers differ).
Signed-off-by: Martin Gebert <Martin.Gebert@alpha-bit.de>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/net/au1000_eth.c')
| -rw-r--r-- | drivers/net/au1000_eth.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index 5ee1b0557a02..92c16c37ff23 100644 --- a/drivers/net/au1000_eth.c +++ b/drivers/net/au1000_eth.c @@ -653,6 +653,8 @@ static struct net_device * au1000_probe(int port_num) aup = dev->priv; + spin_lock_init(&aup->lock); + /* Allocate the data buffers */ /* Snooping works fine with eth on all au1xxx */ aup->vaddr = (u32)dma_alloc_noncoherent(NULL, MAX_BUF_SIZE * @@ -753,7 +755,6 @@ static struct net_device * au1000_probe(int port_num) aup->tx_db_inuse[i] = pDB; } - spin_lock_init(&aup->lock); dev->base_addr = base; dev->irq = irq; dev->open = au1000_open; |