diff options
| author |   Anton Vorontsov <avorontsov@ru.mvista.com> | 2008-07-22 15:41:24 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2008-07-22 15:41:24 -0700 |
| commit | c8f15686a4b3345e3e81e09cfe191df58bbedd45 (patch) | |
| tree | 1990e6281c5ced09566b093c599b7022f7bb4eb8 /drivers/net/au1000_eth.c | |
| parent | ipv6: icmp6_dst_gc return change (diff) | |
| download | linux-dev-c8f15686a4b3345e3e81e09cfe191df58bbedd45.tar.xz linux-dev-c8f15686a4b3345e3e81e09cfe191df58bbedd45.zip | |
netdev: bunch of drivers: avoid WARN at net/core/dev.c:1328
The drivers were touching net queue before it has been started, so
without this patch, the drivers will potentially WARN at
net/core/dev.c:1328.
I don't have the hardware for the drivers below, so this patch is
untested, and thus should be carefully peer reviewed.
tc35815.c
au1000_eth.c
bfin_mac.c
macb.c
^ The four drivers are using phylib, they're calling netif_start_queue()
in open() callback. So trivially remove netif_tx_schedule_all().
Phylib will handle netif_carrier_*().
cpmac.c
fec_mpc52xx.c
fs_enet/fs_enet-main.c
sh_eth.c
^ The same as above, but these were also needlessly calling
netif_carrier_*() functions. So removed queue calls and also remove
carrier calls, since phylib will handle it. fs_enet-main.c also didn't
call netif_start_queue() at open(), this is fixed now.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/au1000_eth.c')
| -rw-r--r-- | drivers/net/au1000_eth.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index 3ab61e40e86a..cb8be490e5ae 100644 --- a/drivers/net/au1000_eth.c +++ b/drivers/net/au1000_eth.c @@ -911,9 +911,8 @@ au1000_adjust_link(struct net_device *dev) if(phydev->link != aup->old_link) { // link state changed - if (phydev->link) // link went up - netif_tx_schedule_all(dev); - else { // link went down + if (!phydev->link) { + /* link went down */ aup->old_speed = 0; aup->old_duplex = -1; } |