diff options
| author |   Mahesh Bandewar <maheshb@google.com> | 2017-03-27 11:37:40 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-03-27 21:11:50 -0700 |
| commit | e292dcae1648cd5b5c80031a154f594aa590667f (patch) | |
| tree | 20269c62b0a9d0ff31acb4421f54fedd9f2291cc /drivers/net/bonding/bond_3ad.c | |
| parent | bonding: correctly update link status during mii-commit phase (diff) | |
| download | linux-dev-e292dcae1648cd5b5c80031a154f594aa590667f.tar.xz linux-dev-e292dcae1648cd5b5c80031a154f594aa590667f.zip | |
bonding: avoid printing while holding a spinlock
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_3ad.c')
| -rw-r--r-- | drivers/net/bonding/bond_3ad.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 508713b4e533..c5fd4259da33 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c @@ -2446,9 +2446,9 @@ void bond_3ad_adapter_speed_duplex_changed(struct slave *slave) spin_lock_bh(&slave->bond->mode_lock); ad_update_actor_keys(port, false); + spin_unlock_bh(&slave->bond->mode_lock); netdev_dbg(slave->bond->dev, "Port %d slave %s changed speed/duplex\n", port->actor_port_number, slave->dev->name); - spin_unlock_bh(&slave->bond->mode_lock); } /** @@ -2492,12 +2492,12 @@ void bond_3ad_handle_link_change(struct slave *slave, char link) agg = __get_first_agg(port); ad_agg_selection_logic(agg, &dummy); + spin_unlock_bh(&slave->bond->mode_lock); + netdev_dbg(slave->bond->dev, "Port %d changed link status to %s\n", port->actor_port_number, link == BOND_LINK_UP ? "UP" : "DOWN"); - spin_unlock_bh(&slave->bond->mode_lock); - /* RTNL is held and mode_lock is released so it's safe * to update slave_array here. */ |