diff options
| author |   Ido Schimmel <idosch@nvidia.com> | 2021-02-10 22:43:33 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-02-11 14:28:21 -0800 |
| commit | 5edf55ad95b5d5e444a7d104276c4b64a045adc3 (patch) | |
| tree | e14f9c8d157d224d78dbdf4e6cef4ff39a74b4af /drivers/net/bonding | |
| parent | bonding: 3ad: add support for 400G speed (diff) | |
| download | linux-dev-5edf55ad95b5d5e444a7d104276c4b64a045adc3.tar.xz linux-dev-5edf55ad95b5d5e444a7d104276c4b64a045adc3.zip | |
bonding: 3ad: Print an error for unknown speeds
The bond driver needs to be patched to support new ethtool speeds.
Currently it emits a single warning [1] when it encounters an unknown
speed. As evident by the two previous patches, this is not explicit
enough. Instead, promote it to an error.
[1]
bond10: (slave swp1): unknown ethtool speed (200000) for port 1 (set it to 0)
v2:
* Use pr_err_once() instead of WARN_ONCE()
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding')
| -rw-r--r-- | drivers/net/bonding/bond_3ad.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 2e670f68626d..6908822d9773 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c @@ -327,10 +327,10 @@ static u16 __get_link_speed(struct port *port) default: /* unknown speed value from ethtool. shouldn't happen */ if (slave->speed != SPEED_UNKNOWN) - pr_warn_once("%s: (slave %s): unknown ethtool speed (%d) for port %d (set it to 0)\n", - slave->bond->dev->name, - slave->dev->name, slave->speed, - port->actor_port_number); + pr_err_once("%s: (slave %s): unknown ethtool speed (%d) for port %d (set it to 0)\n", + slave->bond->dev->name, + slave->dev->name, slave->speed, + port->actor_port_number); speed = 0; break; } |