diff options
| author |   Herbert Xu <herbert@gondor.apana.org.au> | 2014-12-22 20:35:25 +1100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-12-22 16:34:39 -0500 |
| commit | 3079c652141f9d6377417a7e8fd650c9948df65e (patch) | |
| tree | cc7f3f21c07534f6268535ff41b60df6dfbb1aeb /drivers/net/caif | |
| parent | net/mlx4_en: Doorbell is byteswapped in Little Endian archs (diff) | |
| download | linux-dev-3079c652141f9d6377417a7e8fd650c9948df65e.tar.xz linux-dev-3079c652141f9d6377417a7e8fd650c9948df65e.zip | |
caif: Fix napi poll list corruption
The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less
interrupt masking in NAPI) breaks caif.
It is now required that if the entire budget is consumed when poll
returns, the napi poll_list must remain empty. However, like some
other drivers caif tries to do a last-ditch check and if there is
more work it will call napi_schedule and then immediately process
some of this new work. Should the entire budget be consumed while
processing such new work then we will violate the new caller
contract.
This patch fixes this by not touching any work when we reschedule
in caif.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/caif')
| -rw-r--r-- | drivers/net/caif/caif_virtio.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c index a5fefb9059c5..b306210b02b7 100644 --- a/drivers/net/caif/caif_virtio.c +++ b/drivers/net/caif/caif_virtio.c @@ -257,7 +257,6 @@ static int cfv_rx_poll(struct napi_struct *napi, int quota) struct vringh_kiov *riov = &cfv->ctx.riov; unsigned int skb_len; -again: do { skb = NULL; @@ -322,7 +321,6 @@ exit: napi_schedule_prep(napi)) { vringh_notify_disable_kern(cfv->vr_rx); __napi_schedule(napi); - goto again; } break; |