diff options
| author |   Dario Binacchi <dariobin@libero.it> | 2021-03-02 22:54:32 +0100 |
|---|---|---|
| committer |   Marc Kleine-Budde <mkl@pengutronix.de> | 2021-03-30 11:14:53 +0200 |
| commit | eddf67115040b9e875e8a153816df89f66b4c5b6 (patch) | |
| tree | 3e81273047753c939af1fa1e9cd5283c5891371d /drivers/net/can/c_can | |
| parent | can: c_can: fix indentation (diff) | |
| download | linux-dev-eddf67115040b9e875e8a153816df89f66b4c5b6.tar.xz linux-dev-eddf67115040b9e875e8a153816df89f66b4c5b6.zip | |
can: c_can: add a comment about IF_RX interface's use
After reading the commit 640916db2bf7 ("can: c_can: Make it SMP safe")
it may sound strange to see the IF_RX interface used by the
can_inval_tx_object function. A comment was added to avoid any
misunderstanding.
Link: https://lore.kernel.org/r/20210302215435.18286-4-dariobin@libero.it
Signed-off-by: Dario Binacchi <dariobin@libero.it>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/c_can')
| -rw-r--r-- | drivers/net/can/c_can/c_can.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index 8212f3d98aa9..980abf6a8609 100644 --- a/drivers/net/can/c_can/c_can.c +++ b/drivers/net/can/c_can/c_can.c @@ -710,6 +710,11 @@ static void c_can_do_tx(struct net_device *dev) idx--; pend &= ~(1 << idx); obj = idx + C_CAN_MSG_OBJ_TX_FIRST; + + /* We use IF_RX interface instead of IF_TX because we + * are called from c_can_poll(), which runs inside + * NAPI. We are not trasmitting. + */ c_can_inval_tx_object(dev, IF_RX, obj); can_get_echo_skb(dev, idx, NULL); bytes += priv->dlc[idx]; |