diff options
| author |   Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-10-20 22:36:52 -0500 |
|---|---|---|
| committer |   Marc Kleine-Budde <mkl@pengutronix.de> | 2019-11-11 21:57:28 +0100 |
| commit | 371fd7baa81d2adb05c390f8f8a42a4f02173cbd (patch) | |
| tree | 85ea1d344a1285fa3c50183b547611b76d4941a9 /drivers/net/can/dev.c | |
| parent | Support LAN743x PTP periodic output on any GPIO (diff) | |
| download | linux-dev-371fd7baa81d2adb05c390f8f8a42a4f02173cbd.tar.xz linux-dev-371fd7baa81d2adb05c390f8f8a42a4f02173cbd.zip | |
can: dev: can_restart(): remove unused code
Value assigned to variable err is overwritten at line
562: err = priv->do_set_mode(dev, CAN_MODE_START); before
it can be used.
Also, notice that this code has been there since 2014.
Addresses-Coverity-ID: 1227031
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/dev.c')
| -rw-r--r-- | drivers/net/can/dev.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 1c88c361938c..6ee06a49fb4c 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -553,10 +553,9 @@ static void can_restart(struct net_device *dev) /* send restart message upstream */ skb = alloc_can_err_skb(dev, &cf); - if (!skb) { - err = -ENOMEM; + if (!skb) goto restart; - } + cf->can_id |= CAN_ERR_RESTARTED; netif_rx(skb); |