diff options
| author |   Marc Kleine-Budde <mkl@pengutronix.de> | 2021-05-02 11:34:34 +0200 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2021-05-06 09:24:06 +0200 |
| commit | 4376ea42db8bfcac2bc3a30bba93917244a8c2d4 (patch) | |
| tree | 6b647fa2cd33fef1d3286f516e3659a1bc790ffb /drivers/net/can/spi | |
| parent | can: mcp251xfd: mcp251xfd_probe(): fix an error pointer dereference in probe (diff) | |
| download | linux-dev-4376ea42db8bfcac2bc3a30bba93917244a8c2d4.tar.xz linux-dev-4376ea42db8bfcac2bc3a30bba93917244a8c2d4.zip | |
can: mcp251xfd: mcp251xfd_probe(): add missing can_rx_offload_del() in error path
This patch adds the missing can_rx_offload_del(), that must be called
if mcp251xfd_register() fails.
Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Link: https://lore.kernel.org/r/20210504091838.1109047-1-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/spi')
| -rw-r--r-- | drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c index f122976e90da..e0ae00e34c7b 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c @@ -2986,10 +2986,12 @@ static int mcp251xfd_probe(struct spi_device *spi) err = mcp251xfd_register(priv); if (err) - goto out_free_candev; + goto out_can_rx_offload_del; return 0; + out_can_rx_offload_del: + can_rx_offload_del(&priv->offload); out_free_candev: spi->max_speed_hz = priv->spi_max_speed_hz_orig; |