diff options
| author |   Stephane Grosjean <s.grosjean@peak-system.com> | 2021-06-25 15:09:27 +0200 |
|---|---|---|
| committer |   Marc Kleine-Budde <mkl@pengutronix.de> | 2021-07-25 11:36:28 +0200 |
| commit | 1d0214a0f5db10d5dc37f4da980786cd094ae3e4 (patch) | |
| tree | 58fe427101a1e471dd2d4087e07a87270708cecd /drivers/net/can/usb/peak_usb | |
| parent | can: peak_pci: Add name and FW version of the card in kernel buffer (diff) | |
| download | linux-dev-1d0214a0f5db10d5dc37f4da980786cd094ae3e4.tar.xz linux-dev-1d0214a0f5db10d5dc37f4da980786cd094ae3e4.zip | |
can: peak_usb: pcan_usb_get_device_id(): read value only in case of success
In case of error, reading value from response argument is useless.
Link: https://lore.kernel.org/r/20210625130931.27438-2-s.grosjean@peak-system.com
Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/usb/peak_usb')
| -rw-r--r-- | drivers/net/can/usb/peak_usb/pcan_usb.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb.c b/drivers/net/can/usb/peak_usb/pcan_usb.c index 1d6f77252f01..9f3e16684e28 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb.c @@ -384,7 +384,8 @@ static int pcan_usb_get_device_id(struct peak_usb_device *dev, u32 *device_id) if (err) netdev_err(dev->netdev, "getting device id failure: %d\n", err); - *device_id = args[0]; + else + *device_id = args[0]; return err; } |