diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2021-04-15 09:47:23 +0100 |
|---|---|---|
| committer |   Marc Kleine-Budde <mkl@pengutronix.de> | 2021-04-24 14:36:50 +0200 |
| commit | 2ce4fd5a0039b805a6716779e8669dd69a20ad60 (patch) | |
| tree | 5063d83b17f9329b0aa4614695f8378163ee8198 /drivers/net/can/usb | |
| parent | phy: nxp-c45-tja11xx: add interrupt support (diff) | |
| download | linux-dev-2ce4fd5a0039b805a6716779e8669dd69a20ad60.tar.xz linux-dev-2ce4fd5a0039b805a6716779e8669dd69a20ad60.zip | |
can: etas_es58x: Fix missing null check on netdev pointer
There is an assignment to *netdev that is that can potentially be null
but the null check is checking netdev and not *netdev as intended. Fix
this by adding in the missing * operator.
Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Link: https://lore.kernel.org/r/20210415084723.1807935-1-colin.king@canonical.com
Addresses-Coverity: ("Dereference before null check")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/usb')
| -rw-r--r-- | drivers/net/can/usb/etas_es58x/es58x_core.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.h b/drivers/net/can/usb/etas_es58x/es58x_core.h index 5f4e7dc5be35..fcf219e727bf 100644 --- a/drivers/net/can/usb/etas_es58x/es58x_core.h +++ b/drivers/net/can/usb/etas_es58x/es58x_core.h @@ -625,7 +625,7 @@ static inline int es58x_get_netdev(struct es58x_device *es58x_dev, return -ECHRNG; *netdev = es58x_dev->netdev[channel_idx]; - if (!netdev || !netif_device_present(*netdev)) + if (!*netdev || !netif_device_present(*netdev)) return -ENODEV; return 0; |