diff options
| author |   Ben Hutchings <bhutchings@solarflare.com> | 2009-09-03 10:39:43 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-09-03 20:02:11 -0700 |
| commit | 7ab0f2736bfe137a82a7084bbfb5f809da95cabd (patch) | |
| tree | e305ec96eceebb285efee4b6fd307822ab257fe6 /drivers/net/cassini.c | |
| parent | netdev: Remove SIOCDEVPRIVATE aliases for MDIO ioctls (diff) | |
| download | linux-dev-7ab0f2736bfe137a82a7084bbfb5f809da95cabd.tar.xz linux-dev-7ab0f2736bfe137a82a7084bbfb5f809da95cabd.zip | |
netdev: Remove redundant checks for CAP_NET_ADMIN in MDIO implementations
dev_ioctl() already checks capable(CAP_NET_ADMIN) before calling the
driver's implementation of MDIO ioctls.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/cassini.c')
| -rw-r--r-- | drivers/net/cassini.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c index 7517dc1da650..05916aafa4f1 100644 --- a/drivers/net/cassini.c +++ b/drivers/net/cassini.c @@ -4875,10 +4875,6 @@ static int cas_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) break; case SIOCSMIIREG: /* Write MII PHY register. */ - if (!capable(CAP_NET_ADMIN)) { - rc = -EPERM; - break; - } spin_lock_irqsave(&cp->lock, flags); cas_mif_poll(cp, 0); rc = cas_phy_write(cp, data->reg_num & 0x1f, data->val_in); |