aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/dsa/bcm_sf2.h
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2019-02-06 19:39:52 +0100
committerDavid S. Miller <davem@davemloft.net>2019-02-08 22:09:11 -0800
commit93c0970493c71f264e6c3c7caf1ff24a9e1de786 (patch)
tree11cb71c6107c6250d9a93458932b0f6e550b39cf /drivers/net/dsa/bcm_sf2.h
parentnet: macb: add sam9x60-macb compatibility string (diff)
downloadlinux-dev-93c0970493c71f264e6c3c7caf1ff24a9e1de786.tar.xz
linux-dev-93c0970493c71f264e6c3c7caf1ff24a9e1de786.zip
net: phy: consider latched link-down status in polling mode
The link status value latches link-down events. To get the current status we read the register twice in genphy_update_link(). There's a potential risk that we miss a link-down event in polling mode. This may cause issues if the user e.g. connects his machine to a different network. On the other hand reading the latched value may cause issues in interrupt mode. Following scenario: - After boot link goes up - phy_start() is called triggering an aneg restart, hence link goes down and link-down info is latched. - After aneg has finished link goes up and triggers an interrupt. Interrupt handler reads link status, means it reads the latched "link is down" info. But there won't be another interrupt as long as link stays up, therefore phylib will never recognize that link is up. Deal with both scenarios by reading the register twice in interrupt mode only. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/bcm_sf2.h')
0 files changed, 0 insertions, 0 deletions