diff options
| author |   Phil Reid <preid@electromag.com.au> | 2018-01-10 15:39:32 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-01-15 13:18:02 -0500 |
| commit | a57d476d9707a470bbdcbd1ab00df73b55650bf7 (patch) | |
| tree | bf10206c04004899fd1d56ca18480362f6263880 /drivers/net/dsa/lan9303-core.c | |
| parent | net: phy: Have __phy_modify return 0 on success (diff) | |
| download | linux-dev-a57d476d9707a470bbdcbd1ab00df73b55650bf7.tar.xz linux-dev-a57d476d9707a470bbdcbd1ab00df73b55650bf7.zip | |
net: dsa: lan9303: make lan9303_handle_reset() a void function
lan9303_handle_reset never returns anything other than success.
So there's not need for it to return an error code.
Signed-off-by: Phil Reid <preid@electromag.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/lan9303-core.c')
| -rw-r--r-- | drivers/net/dsa/lan9303-core.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index 2dead7fa1f93..4ad7dbea2a6f 100644 --- a/drivers/net/dsa/lan9303-core.c +++ b/drivers/net/dsa/lan9303-core.c @@ -817,18 +817,16 @@ static void lan9303_bridge_ports(struct lan9303 *chip) lan9303_alr_add_port(chip, eth_stp_addr, 0, true); } -static int lan9303_handle_reset(struct lan9303 *chip) +static void lan9303_handle_reset(struct lan9303 *chip) { if (!chip->reset_gpio) - return 0; + return; if (chip->reset_duration != 0) msleep(chip->reset_duration); /* release (deassert) reset and activate the device */ gpiod_set_value_cansleep(chip->reset_gpio, 0); - - return 0; } /* stop processing packets for all ports */ @@ -1328,9 +1326,7 @@ int lan9303_probe(struct lan9303 *chip, struct device_node *np) lan9303_probe_reset_gpio(chip, np); - ret = lan9303_handle_reset(chip); - if (ret) - return ret; + lan9303_handle_reset(chip); ret = lan9303_check_device(chip); if (ret) |