aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/dsa/sja1105/sja1105_ethtool.c
diff options
context:
space:
mode:
authorVladimir Oltean <olteanv@gmail.com>2019-10-01 22:18:00 +0300
committerDavid S. Miller <davem@davemloft.net>2019-10-02 12:25:11 -0400
commitdff79620c3e8c3a1793e0e4751b8cd7bd15f1565 (patch)
tree24ac912ad1e43630f7ea06df46c0e4b3cda0f100 /drivers/net/dsa/sja1105/sja1105_ethtool.c
parentnet: dsa: sja1105: Don't use "inline" function declarations in C files (diff)
downloadlinux-dev-dff79620c3e8c3a1793e0e4751b8cd7bd15f1565.tar.xz
linux-dev-dff79620c3e8c3a1793e0e4751b8cd7bd15f1565.zip
net: dsa: sja1105: Replace sja1105_spi_send_int with sja1105_xfer_{u32, u64}
Having a function that takes a variable number of unpacked bytes which it generically calls an "int" is confusing and makes auditing patches next to impossible. We only use spi_send_int with the int sizes of 32 and 64 bits. So just make the spi_send_int function less generic and replace it with the appropriate two explicit functions, which can now type-check the int pointer type. Note that there is still a small weirdness in the u32 function, which has to convert it to a u64 temporary. This is because of how the packing API works at the moment, but the weirdness is at least hidden from callers of sja1105_xfer_u32 now. Suggested-by: David S. Miller <davem@davemloft.net> Signed-off-by: Vladimir Oltean <olteanv@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/sja1105/sja1105_ethtool.c')
0 files changed, 0 insertions, 0 deletions