diff options
| author |   Martin KaFai Lau <kafai@fb.com> | 2019-09-27 16:00:31 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-09-30 17:13:43 -0700 |
| commit | 8c7138b33e5c690c308b2a7085f6313fdcb3f616 (patch) | |
| tree | 7b75bde03bddc203db1a1b91f90f0b09fdf5ccd1 /drivers/net/dsa/sja1105/sja1105_main.c | |
| parent | erspan: remove the incorrect mtu limit for erspan (diff) | |
| download | linux-dev-8c7138b33e5c690c308b2a7085f6313fdcb3f616.tar.xz linux-dev-8c7138b33e5c690c308b2a7085f6313fdcb3f616.zip | |
net: Unpublish sk from sk_reuseport_cb before call_rcu
The "reuse->sock[]" array is shared by multiple sockets. The going away
sk must unpublish itself from "reuse->sock[]" before making call_rcu()
call. However, this unpublish-action is currently done after a grace
period and it may cause use-after-free.
The fix is to move reuseport_detach_sock() to sk_destruct().
Due to the above reason, any socket with sk_reuseport_cb has
to go through the rcu grace period before freeing it.
It is a rather old bug (~3 yrs). The Fixes tag is not necessary
the right commit but it is the one that introduced the SOCK_RCU_FREE
logic and this fix is depending on it.
Fixes: a4298e4522d6 ("net: add SOCK_RCU_FREE socket flag")
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/sja1105/sja1105_main.c')
0 files changed, 0 insertions, 0 deletions