diff options
| author |   Alex Marginean <alexandru.marginean@nxp.com> | 2020-01-16 20:05:06 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-01-17 13:14:21 +0100 |
| commit | 062a33b1ad7c8df9f8f03f7b01c18e31a794a01d (patch) | |
| tree | cbd033ea747b630383d92551f1d3e696fd0168c2 /drivers/net/dsa | |
| parent | Documentation: Fix typo in devlink documentation (diff) | |
| download | linux-dev-062a33b1ad7c8df9f8f03f7b01c18e31a794a01d.tar.xz linux-dev-062a33b1ad7c8df9f8f03f7b01c18e31a794a01d.zip | |
net: dsa: felix: Set USXGMII link based on BMSR, not LPA
At least some PHYs (AQR412) don't advertise copper-side link status
during system side AN.
So remove this duplicate assignment to pcs->link and rely on the
previous one for link state: the local indication from the MAC PCS.
Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/ocelot/felix_vsc9959.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c index 03482616faa7..1e82b0d72058 100644 --- a/drivers/net/dsa/ocelot/felix_vsc9959.c +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c @@ -892,7 +892,6 @@ static void vsc9959_pcs_link_state_usxgmii(struct phy_device *pcs, break; } - pcs->link = USXGMII_LPA_LNKS(lpa); if (USXGMII_LPA_DUPLEX(lpa)) pcs->duplex = DUPLEX_FULL; else |