diff options
| author |   Vivien Didelot <vivien.didelot@savoirfairelinux.com> | 2017-08-01 16:32:32 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-08-01 20:09:09 -0700 |
| commit | 06d7b5c3acee7b42cd9aa47165587b9c1fb992d3 (patch) | |
| tree | 33b0901b953ece0409d6c0b2f59062a122506e95 /drivers/net/dsa | |
| parent | net: dsa: PHY device is mandatory for EEE (diff) | |
| download | linux-dev-06d7b5c3acee7b42cd9aa47165587b9c1fb992d3.tar.xz linux-dev-06d7b5c3acee7b42cd9aa47165587b9c1fb992d3.zip | |
net: dsa: qca8k: fix EEE init
The qca8k obviously copied code from the sf2 driver as how to set EEE:
if (e->eee_enabled) {
p->eee_enabled = qca8k_eee_init(ds, port, phydev);
if (!p->eee_enabled)
ret = -EOPNOTSUPP;
}
But it did not use the same logic for the EEE init routine, which is
"Returns 0 if EEE was not enabled, or 1 otherwise". This results in
returning -EOPNOTSUPP on success and caching EEE enabled on failure.
This patch fixes the returned value of qca8k_eee_init.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/qca8k.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index b3bee7eab45f..e076ab23d4df 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -666,11 +666,11 @@ qca8k_eee_init(struct dsa_switch *ds, int port, ret = phy_init_eee(phy, 0); if (ret) - return ret; + return 0; qca8k_eee_enable_set(ds, port, true); - return 0; + return 1; } static int |