diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2021-06-15 10:05:16 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-15 11:28:01 -0700 |
| commit | 11b57faf951cd3a570e3d9e463fc7c41023bc8c6 (patch) | |
| tree | e4b4e6496410173228c881b357523b6673e7b2ea /drivers/net/dsa | |
| parent | net: bonding: Use per-cpu rr_tx_counter (diff) | |
| download | linux-dev-11b57faf951cd3a570e3d9e463fc7c41023bc8c6.tar.xz linux-dev-11b57faf951cd3a570e3d9e463fc7c41023bc8c6.zip | |
net: dsa: b53: remove redundant null check on dev
The pointer dev can never be null, the null check is redundant
and can be removed. Cleans up a static analysis warning that
pointer priv is dereferencing dev before dev is being null
checked.
Addresses-Coverity: ("Dereference before null check")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/b53/b53_srab.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c index aaa12d73784e..3f4249de70c5 100644 --- a/drivers/net/dsa/b53/b53_srab.c +++ b/drivers/net/dsa/b53/b53_srab.c @@ -632,8 +632,7 @@ static int b53_srab_remove(struct platform_device *pdev) struct b53_srab_priv *priv = dev->priv; b53_srab_intr_set(priv, false); - if (dev) - b53_switch_remove(dev); + b53_switch_remove(dev); return 0; } |