diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2019-10-24 11:32:18 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-28 13:38:06 -0700 |
| commit | 556f124fb30621df3089d624ac57f13744712753 (patch) | |
| tree | aae66c0e0c71280765c3a66da28a8e6dab2152d5 /drivers/net/dsa | |
| parent | Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next (diff) | |
| download | linux-dev-556f124fb30621df3089d624ac57f13744712753.tar.xz linux-dev-556f124fb30621df3089d624ac57f13744712753.zip | |
net: dsa: fix dereference on ds->dev before null check error
Currently ds->dev is dereferenced on the assignments of pdata and
np before ds->dev is null checked, hence there is a potential null
pointer dereference on ds->dev. Fix this by assigning pdata and
np after the ds->dev null pointer sanity check.
Addresses-Coverity: ("Dereference before null check")
Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
0 files changed, 0 insertions, 0 deletions