diff options
| author |   Vladimir Oltean <olteanv@gmail.com> | 2019-04-28 21:45:47 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-04-30 23:05:28 -0400 |
| commit | e3ee07d14fac20ce12e93a72048fa6fd51348826 (patch) | |
| tree | 496894544e4d14a56519a5d351d04819d6637308 /drivers/net/dsa | |
| parent | net: dsa: Unset vlan_filtering when ports leave the bridge (diff) | |
| download | linux-dev-e3ee07d14fac20ce12e93a72048fa6fd51348826.tar.xz linux-dev-e3ee07d14fac20ce12e93a72048fa6fd51348826.zip | |
net: dsa: mt7530: Let DSA handle the unsetting of vlan_filtering
The driver, recognizing that the .port_vlan_filtering callback was never
coming after the port left its parent bridge, decided to take that duty
in its own hands. DSA now takes care of this condition, so fix that.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/mt7530.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 7357b4fc0185..3530b6f38428 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -910,8 +910,6 @@ mt7530_port_bridge_leave(struct dsa_switch *ds, int port, PCR_MATRIX(BIT(MT7530_CPU_PORT))); priv->ports[port].pm = PCR_MATRIX(BIT(MT7530_CPU_PORT)); - mt7530_port_set_vlan_unaware(ds, port); - mutex_unlock(&priv->reg_mutex); } @@ -1025,6 +1023,8 @@ mt7530_port_vlan_filtering(struct dsa_switch *ds, int port, */ mt7530_port_set_vlan_aware(ds, port); mt7530_port_set_vlan_aware(ds, MT7530_CPU_PORT); + } else { + mt7530_port_set_vlan_unaware(ds, port); } return 0; |