diff options
| author |   Wei Yongjun <weiyongjun1@huawei.com> | 2018-09-15 01:33:38 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-09-17 08:06:19 -0700 |
| commit | f592e0b9895cd6f04ba2771a3903317dd7c1ba31 (patch) | |
| tree | 93bc3da6307e42edc159a93b5e8455a8ccbfa85b /drivers/net/dsa | |
| parent | net: dsa: gswip: Fix return value check in gswip_probe() (diff) | |
| download | linux-dev-f592e0b9895cd6f04ba2771a3903317dd7c1ba31.tar.xz linux-dev-f592e0b9895cd6f04ba2771a3903317dd7c1ba31.zip | |
net: dsa: gswip: Fix copy-paste error in gswip_gphy_fw_probe()
The return value from of_reset_control_array_get_exclusive() is not
checked correctly. The test is done against a wrong variable. This
patch fix it.
Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/lantiq_gswip.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c index faac35909743..be1e69911a55 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -934,10 +934,10 @@ static int gswip_gphy_fw_probe(struct gswip_priv *priv, } gphy_fw->reset = of_reset_control_array_get_exclusive(gphy_fw_np); - if (IS_ERR(priv->gphy_fw)) { - if (PTR_ERR(priv->gphy_fw) != -EPROBE_DEFER) + if (IS_ERR(gphy_fw->reset)) { + if (PTR_ERR(gphy_fw->reset) != -EPROBE_DEFER) dev_err(dev, "Failed to lookup gphy reset\n"); - return PTR_ERR(priv->gphy_fw); + return PTR_ERR(gphy_fw->reset); } return gswip_gphy_fw_load(priv, gphy_fw); |