diff options
| author |   Stephen Hemminger <shemminger@linux-foundation.org> | 2007-10-29 10:46:19 -0700 |
|---|---|---|
| committer |   Jeff Garzik <jeff@garzik.org> | 2007-10-30 14:32:17 -0400 |
| commit | abec42a4f87795766f77e4595b7e540b5fc60e3f (patch) | |
| tree | accf9def87efcf8b04728aaea44fdecdea0c559e /drivers/net/e1000/e1000_hw.c | |
| parent | ixgb: fix sparse warnings (diff) | |
| download | linux-dev-abec42a4f87795766f77e4595b7e540b5fc60e3f.tar.xz linux-dev-abec42a4f87795766f77e4595b7e540b5fc60e3f.zip | |
e1000: sparse warnings fixes
Fix sparse warnings and problems from e1000 driver.
Added a sparse fix for the module param array index
-- Auke
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/e1000/e1000_hw.c')
| -rw-r--r-- | drivers/net/e1000/e1000_hw.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/e1000/e1000_hw.c b/drivers/net/e1000/e1000_hw.c index 8fa0fe4009d5..7c6888c58c21 100644 --- a/drivers/net/e1000/e1000_hw.c +++ b/drivers/net/e1000/e1000_hw.c @@ -8607,7 +8607,7 @@ e1000_read_ich8_data(struct e1000_hw *hw, uint32_t index, DEBUGFUNC("e1000_read_ich8_data"); - if (size < 1 || size > 2 || data == 0x0 || + if (size < 1 || size > 2 || data == NULL || index > ICH_FLASH_LINEAR_ADDR_MASK) return error; @@ -8841,7 +8841,7 @@ e1000_read_ich8_word(struct e1000_hw *hw, uint32_t index, uint16_t *data) * amount of NVM used in each bank is a *minimum* of 4 KBytes, but in fact the * bank size may be 4, 8 or 64 KBytes *****************************************************************************/ -int32_t +static int32_t e1000_erase_ich8_4k_segment(struct e1000_hw *hw, uint32_t bank) { union ich8_hws_flash_status hsfsts; |