diff options
| author |   Patrick McHardy <kaber@trash.net> | 2011-01-20 03:00:42 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2011-01-20 23:28:54 -0800 |
| commit | ffa934f192c8381061242eb170419266ef229902 (patch) | |
| tree | fb09699460d85166bfa64c524eb6eda01b899c4a /drivers/net/e1000e/netdev.c | |
| parent | ppp: Use SKB queue abstraction interfaces in fragment processing. (diff) | |
| download | linux-dev-ffa934f192c8381061242eb170419266ef229902.tar.xz linux-dev-ffa934f192c8381061242eb170419266ef229902.zip | |
rtnetlink: fix link attribute validation with IFLA_GROUP
rtnl_group_changelink() is invoked by rtnl_newlink() before the link
attributes have been validated. Additionally the group changes are
performed even if NLM_F_CREATE is specified and a new link is
created, while more reasonable semantics would be to set the group
value on the newly created link.
Fix both problems by moving the rtnl_group_changelink() invocation
down to the handling of non-existant links without NLM_F_CREATE()
and add a dev_set_group() call to rtnl_create_link().
Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Vlad Dogaru <ddvlad@rosedu.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/e1000e/netdev.c')
0 files changed, 0 insertions, 0 deletions