diff options
| author |   Jakub Kicinski <kuba@kernel.org> | 2022-01-07 19:44:38 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-01-09 16:52:12 -0800 |
| commit | 009e4ee381a0b6176969fe3026fc5eafe05705d0 (patch) | |
| tree | 9d6cbb22221a05704044c9fadc127b65f5c79346 /drivers/net/ethernet/allwinner/sun4i-emac.c | |
| parent | page_pool: remove spinlock in page_pool_refill_alloc_cache() (diff) | |
| download | linux-dev-009e4ee381a0b6176969fe3026fc5eafe05705d0.tar.xz linux-dev-009e4ee381a0b6176969fe3026fc5eafe05705d0.zip | |
net: allwinner: Fix print format
Kees reports quoted commit introduced the following warning on arm64:
drivers/net/ethernet/allwinner/sun4i-emac.c:922:60: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
922 | netdev_info(ndev, "get io resource from device: 0x%x, size = %u\n",
| ~^
| | | unsigned int
| %llx
923 | regs->start, resource_size(regs));
| ~~~~~~~~~~~
| |
| resource_size_t {aka long long unsigned int}
.. and another one like that for resource_size().
Switch to %pa and a cast.
Reported-by: Kees Cook <keescook@chromium.org>
Fixes: 47869e82c8b8 ("sun4i-emac.c: add dma support")
Link: https://lore.kernel.org/r/20220108034438.2227343-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/allwinner/sun4i-emac.c')
| -rw-r--r-- | drivers/net/ethernet/allwinner/sun4i-emac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c index 964227e342ee..849de4564709 100644 --- a/drivers/net/ethernet/allwinner/sun4i-emac.c +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c @@ -919,8 +919,8 @@ static int emac_configure_dma(struct emac_board_info *db) goto out_clear_chan; } - netdev_info(ndev, "get io resource from device: 0x%x, size = %u\n", - regs->start, resource_size(regs)); + netdev_info(ndev, "get io resource from device: %pa, size = %u\n", + ®s->start, (unsigned int)resource_size(regs)); db->emac_rx_fifo = regs->start + EMAC_RX_IO_DATA_REG; db->rx_chan = dma_request_chan(&pdev->dev, "rx"); |