diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2021-12-03 13:11:28 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-12-03 14:23:11 +0000 |
| commit | badd7857f5c933a3dc34942a2c11d67fdbdc24de (patch) | |
| tree | 7c45bab6ca8d92e0e5cd4fb54e7a80ea2acba1e6 /drivers/net/ethernet/altera | |
| parent | net: bcm4908: Handle dma_set_coherent_mask error codes (diff) | |
| download | linux-dev-badd7857f5c933a3dc34942a2c11d67fdbdc24de.tar.xz linux-dev-badd7857f5c933a3dc34942a2c11d67fdbdc24de.zip | |
net: altera: set a couple error code in probe()
There are two error paths which accidentally return success instead of
a negative error code.
Fixes: bbd2190ce96d ("Altera TSE: Add main and header file for Altera Ethernet Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/altera')
| -rw-r--r-- | drivers/net/ethernet/altera/altera_tse_main.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index d75d95a97dd9..993b2fb42961 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c @@ -1430,16 +1430,19 @@ static int altera_tse_probe(struct platform_device *pdev) priv->rxdescmem_busaddr = dma_res->start; } else { + ret = -ENODEV; goto err_free_netdev; } - if (!dma_set_mask(priv->device, DMA_BIT_MASK(priv->dmaops->dmamask))) + if (!dma_set_mask(priv->device, DMA_BIT_MASK(priv->dmaops->dmamask))) { dma_set_coherent_mask(priv->device, DMA_BIT_MASK(priv->dmaops->dmamask)); - else if (!dma_set_mask(priv->device, DMA_BIT_MASK(32))) + } else if (!dma_set_mask(priv->device, DMA_BIT_MASK(32))) { dma_set_coherent_mask(priv->device, DMA_BIT_MASK(32)); - else + } else { + ret = -EIO; goto err_free_netdev; + } /* MAC address space */ ret = request_and_map(pdev, "control_port", &control_port, |