diff options
| author |   Sameeh Jubran <sameehj@amazon.com> | 2019-05-01 16:47:06 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-05-04 00:14:46 -0400 |
| commit | d3cfe7ddbc3dfbb9b201615b7fef8fd66d1b5fe8 (patch) | |
| tree | d64f582ed6fe5b9013d200103b492c3556a87835 /drivers/net/ethernet/amazon | |
| parent | net: ena: fix: Free napi resources when ena_up() fails (diff) | |
| download | linux-dev-d3cfe7ddbc3dfbb9b201615b7fef8fd66d1b5fe8.tar.xz linux-dev-d3cfe7ddbc3dfbb9b201615b7fef8fd66d1b5fe8.zip | |
net: ena: fix incorrect test of supported hash function
ena_com_set_hash_function() tests if a hash function is supported
by the device before setting it.
The test returns the opposite result than needed.
Reverse the condition to return the correct value.
Also use the BIT macro instead of inline shift.
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/amazon')
| -rw-r--r-- | drivers/net/ethernet/amazon/ena/ena_com.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c index b17d435de09f..f9bc0b831a1a 100644 --- a/drivers/net/ethernet/amazon/ena/ena_com.c +++ b/drivers/net/ethernet/amazon/ena/ena_com.c @@ -2195,7 +2195,7 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev) if (unlikely(ret)) return ret; - if (get_resp.u.flow_hash_func.supported_func & (1 << rss->hash_func)) { + if (!(get_resp.u.flow_hash_func.supported_func & BIT(rss->hash_func))) { pr_err("Func hash %d isn't supported by device, abort\n", rss->hash_func); return -EOPNOTSUPP; |