diff options
| author |   Arthur Kiyanovski <akiyano@amazon.com> | 2020-03-17 09:06:42 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-03-17 21:24:23 -0700 |
| commit | dfdde1345bc124816f0fd42fa91b8748051e758e (patch) | |
| tree | ae6294cc7ffa878fd6170cbe2c1a22684d719468 /drivers/net/ethernet/amazon | |
| parent | net: ena: avoid memory access violation by validating req_id properly (diff) | |
| download | linux-dev-dfdde1345bc124816f0fd42fa91b8748051e758e.tar.xz linux-dev-dfdde1345bc124816f0fd42fa91b8748051e758e.zip | |
net: ena: fix continuous keep-alive resets
last_keep_alive_jiffies is updated in probe and when a keep-alive
event is received. In case the driver times-out on a keep-alive event,
it has high chances of continuously timing-out on keep-alive events.
This is because when the driver recovers from the keep-alive-timeout reset
the value of last_keep_alive_jiffies is very old, and if a keep-alive
event is not received before the next timer expires, the value of
last_keep_alive_jiffies will cause another keep-alive-timeout reset
and so forth in a loop.
Solution:
Update last_keep_alive_jiffies whenever the device is restored after
reset.
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Noam Dagan <ndagan@amazon.com>
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/amazon')
| -rw-r--r-- | drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 51333a05c14d..4647d7656761 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -3486,6 +3486,7 @@ static int ena_restore_device(struct ena_adapter *adapter) netif_carrier_on(adapter->netdev); mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ)); + adapter->last_keep_alive_jiffies = jiffies; dev_err(&pdev->dev, "Device reset completed successfully, Driver info: %s\n", version); |