diff options
| author |   Dmitry Bogdanov <dbogdanov@marvell.com> | 2020-02-14 18:44:58 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-02-16 19:03:40 -0800 |
| commit | 5a292c89a84d49b598f8978f154bdda48b1072c0 (patch) | |
| tree | 1ab0828545ca75b84b8e331232d79d0c3629c933 /drivers/net/ethernet/aquantia/atlantic/aq_filters.c | |
| parent | net: atlantic: possible fault in transition to hibernation (diff) | |
| download | linux-dev-5a292c89a84d49b598f8978f154bdda48b1072c0.tar.xz linux-dev-5a292c89a84d49b598f8978f154bdda48b1072c0.zip | |
net: atlantic: fix out of range usage of active_vlans array
fix static checker warning:
drivers/net/ethernet/aquantia/atlantic/aq_filters.c:166 aq_check_approve_fvlan()
error: passing untrusted data to 'test_bit()'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 7975d2aff5af: ("net: aquantia: add support of rx-vlan-filter offload")
Signed-off-by: Dmitry Bogdanov <dbogdanov@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/aquantia/atlantic/aq_filters.c')
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_filters.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_filters.c b/drivers/net/ethernet/aquantia/atlantic/aq_filters.c index 6102251bb909..03ff92bc4a7f 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_filters.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_filters.c @@ -163,7 +163,7 @@ aq_check_approve_fvlan(struct aq_nic_s *aq_nic, } if ((aq_nic->ndev->features & NETIF_F_HW_VLAN_CTAG_FILTER) && - (!test_bit(be16_to_cpu(fsp->h_ext.vlan_tci), + (!test_bit(be16_to_cpu(fsp->h_ext.vlan_tci) & VLAN_VID_MASK, aq_nic->active_vlans))) { netdev_err(aq_nic->ndev, "ethtool: unknown vlan-id specified"); |